https://bugzilla.wikimedia.org/show_bug.cgi?id=51576
Web browser: ---
Bug ID: 51576
Summary: Investigate whether MW_NO_OUTPUT_BUFFER can be removed
from WebStart.php
Product: MediaWiki
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: General/Unknown
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: b...@mzmcbride.com
CC: tstarl...@wikimedia.org
Classification: Unclassified
Mobile Platform: ---
As reported by e0je in #mediawiki earlier today, includes/WebStart.php
currently contains the following line (cf.
<https://git.wikimedia.org/blob/mediawiki%2Fcore.git/cd951c7458abfd91c8564874d5ffe08dc7b1b817/includes%2FWebStart.php#L149>):
---
if ( !defined( 'MW_NO_OUTPUT_BUFFER' ) && ob_get_level() == 0 ) {
---
Searching through the current codebase, there were no other references to
"MW_NO_OUTPUT_BUFFER".
Researching the history found the following:
Tim introduced "MW_NO_OUTPUT_BUFFER" on 2007-02-19:
*
https://git.wikimedia.org/commit/mediawiki%2Fcore.git/28dc3ec8884af80faaa996e72be4f945e8466c95
*
https://git.wikimedia.org/blobdiff/mediawiki%2Fcore.git/28dc3ec8884af80faaa996e72be4f945e8466c95/includes%2FWebStart.php
* https://www.mediawiki.org/wiki/Special:Code/MediaWiki/19996
This change added "MW_NO_OUTPUT_BUFFER" to includes/WebStart.php and
config/index.php.
Brion moved most of config/index.php's logic to config/Installer.php on
2009-08-19:
*
https://git.wikimedia.org/commitdiff/mediawiki%2Fcore.git/eec1e42eea8657172f5f226ef13412e12703cfa5
* https://www.mediawiki.org/wiki/Special:Code/MediaWiki/55330
Chad H. deleted config/Installer.php on 2010-12-10:
*
https://git.wikimedia.org/commit/mediawiki%2Fcore.git/fc16010af31a353c6fc0ad8c0020920c8ff1cacf
* https://www.mediawiki.org/wiki/Special:Code/MediaWiki/78180
As far as I can tell, MW_NO_OUTPUT_BUFFER is no longer defined in the codebase
and the check in includes/WebStart.php is no longer needed. But perhaps I'm
mistaken.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
