https://bugzilla.wikimedia.org/show_bug.cgi?id=46836

--- Comment #12 from Krinkle <[email protected]> ---
(In reply to comment #10)
> (In reply to comment #9)
> > So it should just be <= instead of <, right?
> No. The problem is that $i increases while get_level() decreases at the same
> time.

Right, it's obvious now that you pointed it out :)


(In reply to comment #11)
> Is there a reason wfClearOutputBuffers() isn't used here?

Looks like a good candidate at first sight.

HISTORY shows that this was introduced/updated for a similar use case:
> * (bug 8148) Handle non-removable output buffers gracefully when cleaning
>   buffers for HTTP 304 responses, StreamFile, and Special:Export.
>   Duplicated code merged into wfResetOutputBuffers() and 
> wfClearOutputBuffers()

OutputPage::checkLastModified
> $this->getRequest()->response()->header( "HTTP/1.1 304 Not Modified" );
> wfClearOutputBuffers();

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to