https://bugzilla.wikimedia.org/show_bug.cgi?id=20970
Summary: GoogleMaps tries to add icon to toolbar, without
checking it exist
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Keywords: need-review, patch
Severity: minor
Priority: Normal
Component: GoogleMaps
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected]
Created an attachment (id=6617)
--> (https://bugzilla.wikimedia.org/attachment.cgi?id=6617)
changes the inline js to test for the existence of toolbar before doing add
in GoogleMaps.body.php around line 284ish, there is a call to
document.getElementById('toolbar').appendChild(image);
when editing a User:USERNAME/skin.js page, the toolbar is suppressed (for
whatever reason), and does not exist, so the above call fails, and dumps a
javascript error into ye olde browser's error reporting console.
ex: Error: document.getElementById("toolbar") is null
i've added a patch file to attempt to check that it exists, then adds it if it
is present.
i created the file out of wikia's svn, as thats what i had handy.
the linenumbers likely wont match, nor the version numbers, as the two versions
arent entirely in sync, but the differences are minor and not relevant to this
section of code.
i'll be fixing this in wikia's version shortly, just thought i'd share the fix
upstream.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
