https://bugzilla.wikimedia.org/show_bug.cgi?id=52542

--- Comment #1 from Bartosz DziewoƄski <[email protected]> ---
Values that are actually saved in the database (ie, non-default ones) are
always strings, and apparently usually equal to "1" (but for boolean prefs any
truthy value is technically possible, especially if one uses the API to set
them).

Values that are default ones are equal to whatever the programmer decided, and
as you can see they might be 1/0, true/false, "1"/"0" or null. You should just
check for truthiness in this case.

I'm not sure how to solve this, or whether we actually want to solve this;
normalizing values of boolean prefs to true/false just before building this
list (in ResourceLoaderUserOptionsModule#getScript) seems like the best way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to