https://bugzilla.wikimedia.org/show_bug.cgi?id=52324

--- Comment #3 from Kiran Mathew Koshy <kiranmathewko...@gmail.com> ---
(In reply to comment #2)
> (In reply to comment #1)
> > Issue has been resolved.
> 
> If the issue has really been resolved (how?) 

The issue has been resolved. Well, at least it worked on my system. If you
found any errors, please comment.

The objective was to ensure that zimlib sorts the MIME types before writing
them to the file. According to the existing zimlib code, the articles obtained
using getNextArticle() function are collected and stored in dirents, in the
order in which they are obtained. The problem was that the list of MIME Types
is created in the order in which the articles are sent to zimlib, and the
LibraryMimeType code is added to each dirent immediately.

The patch I wrote creates a new sorted list of MIME Types just before writing
to file, and creates a mapping between the old and new LibraryMimeType. All the
dirents are visited again and their LIbrarYMimeTypes are updated using the
mapping.

> and a potential fix has been
> *merged* into the codebase, 

Well, it hasn't been merged into the codebase. I sent it for review, but it
hasn't been approved yet. Tommi manages the commits, and he is on vacation.

> feel free to set RESOLVED status here. :)
I will, as soon as it is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to