https://bugzilla.wikimedia.org/show_bug.cgi?id=53284
Web browser: ---
Bug ID: 53284
Summary: Update markTreeBuilderFixups pass to work without
relying on metas being unfostered out of tables
Product: Parsoid
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: DOM
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
markTreeBuilderFixups analyzes the DOM and tries to find opening and closing
tags added automatically by the tree builder (where they didn't exist in the
token stream) and unbalanced closing tags that got deleted (where they were
present in the token stream).
To do this, it adds shadow meta tags following opening/closing tags in the HTML
token stream fed into the HTML tree builder and sees if the shadow meta has a
corresponding tag in the DOM or if a tag is missing its shadow for its
analysis. However, this analysis requires the shadows to be around at the same
place where they were inserted in the HTML token stream.
Foster-parenting complicates this issue since the shadow metas can be hoisted
out of the table which is the reason why we've hacked the HTML tree builder to
not foster metas.
But, it might be possible to do the analysis without relying on shadow-meta
position. For example, by assigning ids to tags and associating that id with
the shadow-meta might work (or not since tree builder might clone inserted
tags). Or maybe the position can be inferred from the position in the foster
box. Not sure. This is the problem that needs to be solved. Once solved
satisfactorily, our fostering hack in the HTML5 library can be removed.
A lot of wt2html and wt2wt results crucially rely on this information, so
parser tests should accurately tell you what is working or not -- you can test
it by turning off the markTreeBuilderFixups pass and see what happens.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
