https://bugzilla.wikimedia.org/show_bug.cgi?id=42107
Helder <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |code-update-regression, | |javascript CC| |[email protected], | |[email protected] See Also| |https://bugzilla.wikimedia. | |org/show_bug.cgi?id=52479, | |https://bugzilla.wikimedia. | |org/show_bug.cgi?id=51321 Web browser|Firefox |--- --- Comment #5 from Helder <[email protected]> --- This is not Firefox specific (I can reproduce it on Google Chrome 29.0.1547.62). I installed the extension in my copy of MW and added the code ------------------------------------------------------------------------ if( p === 'wikieditor-toolbar-help-content-signaturetimestamp-result' ){ console.log( mw.loader.getState( 'mediawiki.jqueryMsg' ) ); } ------------------------------------------------------------------------ right before the line "return mediaWiki.msg( p );" from the function $.wikiEditor.autoMsg[1]. After reloading the page a few times I noticed the following: * Every time mediawiki.jqueryMsg was "ready" the error occurred * Every time mediawiki.jqueryMsg was "loaded" there was no error So, this bug (as well as bug 52479, and probably the one described on bug 51321 comment 12) only happens when the module "mediawiki.jqueryMsg" changes the behavior of the function "mediaWiki.msg" (also known as "mw.msg"). This shorthand is used by WikiEditor since 2010 (see r75491#115), but on Change-Id: I0d220692262356a12e2f1c0ce30cf6f090428332 the format of the shorthand was modified from "plain" (which WikiEditor was using) to "text". It is likely that using return mediaWiki.message( p ).plain(); would solve this. [1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiEditor.git/8981f855a8dfdb3134da18647bb023d1bff3ad7e/modules%2Fjquery.wikiEditor.js#L151 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
