https://bugzilla.wikimedia.org/show_bug.cgi?id=54210
Web browser: ---
Bug ID: 54210
Summary: ULS: Figure out the problems Wiktionary is having and
deal with it
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: UniversalLanguageSelector
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
If there is a bug or ongoing discussion about this already, feel free to link
it and close this bug. I couldn't find any however.
----------
On the infinite loop journey across site scripts, I had the unfortunate
encounter with the following snippet of code[1]:
<<<
/* There have been literally a hundred thousand comments on the GP about how
ULS breaks the fonts,
so I am copying code kindly provided by [[User:Kephir]] (just made a bit more
suitable for children -
who knows, they might be reading this too!).
If you were wondering why this is found at the very top, well it turns out
there's some kind of
race condition in the ULS code so we want this to run as soon as possible.
Seriously, if I bothered to actually learn JavaScript and invest my time in it
I could do this a
hundred times better than any of the MediaWiki developers. I swear. */
if ($(document.body).data('webfonts')) {
// the damage has been done. undo it.
$('[style], [lang], [class]').css('font-family', '');
}
delete mw.uls;
delete mw.webfonts;
delete $.fn.webfonts;
if (Object.defineProperty) {
// and never come back!
Object.defineProperty(mw, 'uls', { "configurable": false, "set": function
() { throw new Error("error"); } });
Object.defineProperty(mw, 'webfonts', { "configurable": false, "set":
function () { throw new Error("error"); } });
Object.defineProperty($.fn, 'webfonts', { "configurable": false, "set":
function () { throw new Error("error"); } });
}
>>>
Now, I don't know whether they tried to contact the developers first (if not,
that is arguably a small part of blame on them). However now that it has
happened and we know about it, we need to do something about it.
I'm happy to help out in finding a solution (if needed), but as a start, I'd
recommend someone in the language team do the following:
* Find, prioritise and resolve whatever issues are most prominent to the point
that the community is willing to remove this hack.
* Or; if that requires significant development efforts (depends on how big
these bugs are): immediately undeploy ULS from Wiktionary (enwiktionary and
maybe others) and create a tracker bug for the blocking issues.
Undeployment may seem extreme, but the current situation is effectively so
already. Either way, something needs to happen.
[1]
https://en.wiktionary.org/w/index.php?title=MediaWiki:Common.js&oldid=22915160
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
