https://bugzilla.wikimedia.org/show_bug.cgi?id=35858

Krinkle <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|Low                         |Normal
                 CC|                            |[email protected]
            Version|unspecified                 |1.18
   Target Milestone|---                         |1.22.0 release
            Summary|redirectToFragment          |Migrate legacy
                   |shouldn't use legacy        |redirectToFragment to
                   |javascript                  |modern structure

--- Comment #2 from Krinkle <[email protected]> ---
(In reply to comment #0)
> Possible fix: Add a mw.config variable like wgRedirectFragment to the page
> and put the functionality of redirectToFragment() into mediawiki.page.startup.

Sounds good, though maybe in mediawiki.page.ready or mediawiki.util instead.

Things we can clean up:
* Expose fragment target through mw.config (instead of direct invocation by
extra inserted <script> element)
* Avoid creating extra history entries (probably by using location.replace
instead of location.hash = '').
* Move interface from legacy.wikibits to mediawiki.util or mediawiki.page.ready
(either way exposed as a public method as it seems generally useful to be able
to call from code, especially considering the prep work in mw.hook that
encourages this model where we don't make things exclusively available for the
default page load).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to