https://bugzilla.wikimedia.org/show_bug.cgi?id=51479

Remco de Boer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #5 from Remco de Boer <[email protected]> ---
This seems to be related to the parser object. I found what I believe to be the
cause of this behaviour. In SF_FormPrinter, several lines have been commented
out:

(approx l.440)
//        $oldParser = $wgParser;

//        $wgParser = unserialize( serialize( $oldParser ) ); // deep clone of
parser
//        $wgParser->clearState();

(approx l. 1620)
//        $wgParser = $oldParser;

With these lines enabled, the "Some very long..." title is no longer displayed.

However, this does not fix the problematic interaction with ApprovedRevs that
Youri reported, although it is no longer fatal. Approving a page with a red
link that creates another page now results in the error "Database serialization
may cause problems, since the connection is not restored on wakeup." with the
following stack trace:

Backtrace:

#0 [internal function]: DatabaseBase->__sleep()
#1 XXX/extensions/SemanticForms/includes/SF_FormPrinter.php(442):
serialize(Object(Parser))
#2 [internal function]: SFFormPrinter->formHTML('XXX...', false, false, NULL,
NULL, 'Some very long ...', NULL)
#3 XXX/includes/StubObject.php(58): call_user_func_array(Array, Array)
#4 XXX/includes/StubObject.php(77): StubObject->_call('formHTML', Array)
#5 XXX/extensions/SemanticForms/includes/SF_FormLinker.php(169):
StubObject->__call('formHTML', Array)
#6 XXX/extensions/SemanticForms/includes/SF_FormLinker.php(169):
StubObject->formHTML('XXX...', false, false, NULL, NULL, 'Some very long ...',
NULL)
#7 XXX/extensions/SemanticForms/includes/SF_FormLinker.php(288):
SFFormLinker::createLinkedPage(Object(Title), Array)
#8 [internal function]: SFFormLinker::setBrokenLink(Object(DummyLinker),
Object(Title), Array, 'XXX...', Array, NULL)
#9 ...

Does anyone know why the parser-related lines had been commented out in the
first place? Does it have anything to do with the ApprovedRevs error I just
observed? Obviously, commenting out these lines is not a proper solution since
it results in other problems and even fatal errors/endless loops, so I suggest
re-enabling them and fixing the underlying issue. Any ideas?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to