https://bugzilla.wikimedia.org/show_bug.cgi?id=54487

       Web browser: ---
            Bug ID: 54487
           Summary: Non voting failing php unit tests
           Product: Wikimedia
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: Unprioritized
         Component: Continuous integration
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected],
                    [email protected]
    Classification: Unclassified
   Mobile Platform: ---

Jenkins votes with +2 even if PHP-Unit test fail.
See e.g. latest commits in the Math extension.
https://gerrit.wikimedia.org/r/#/c/85801/
I would vote that jenkins only gives +2 if all test were successful. And -1 if
there are failed tests.
If there are skipped test (e.g. because jenkins can not write to the database)
a +1 was fine but +2 gives a wrong impression.
This indicates for a reviewer that he should run the tests locally to vote with
+2 for verification.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to