https://bugzilla.wikimedia.org/show_bug.cgi?id=54567
--- Comment #4 from Kunal Mehta (Legoktm) <[email protected]> --- Looks very nice. There are a few \(minor\) issues that should be fixed though: \* the regexOnly should be added at \*last\* parameter in add\_text, so as not to break API compatibility \* Match was %s""" % result\) doesn't make sense if there is no match \(result will always be \[\]\) and I cnanot see this \(I'm only looking at the diff, lazy me\) - what is the goal of the 'continue' on line 61 of the diff? If I look at the return just above, there is no for loop going on, which makes the continue do nothing... but I may be wrong. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
