https://bugzilla.wikimedia.org/show_bug.cgi?id=54588
Web browser: ---
Bug ID: 54588
Summary: VisualEditor: this.referenceSurface should be a
Surface, not a SurfaceWidget
Product: VisualEditor
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Technical Debt
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected]
Classification: Unclassified
Mobile Platform: ---
In ve.ui.MWReferenceDialog, this.referenceSurface changed from being a Surface
to a SurfaceWidget. I noticed this because I rebased some old code that used
this.referenceSurface.getModel() and broke, but this seems to have happened a
while ago with the introduction of SurfaceWidget.
When a variable name is 'fooSurface', it should be a Surface, not something
else. In particular, you shouldn't have to do
this.referenceSurface.getSurface() to get the surface.
The same applies to this.captionSurface in ve.ui.MWMediaEditDialog.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
