https://bugzilla.wikimedia.org/show_bug.cgi?id=48915

--- Comment #14 from Roan Kattouw <[email protected]> ---
(In reply to comment #13)
> Change 86065 had a related patch set uploaded by Catrope:
> Resolve rendered URLs according to the provided <base>
> 
> https://gerrit.wikimedia.org/r/86065
This addresses the most common symptoms of this bug. It fixes rendering of link
targets for internal links (at least on initial rendering; the href attribute
doesn't update correctly when the link is edited), and it fixes href and src
attributes of things inside of generated content nodes (templates, mostly).

While the change in Gerrit fixes href/src attribute rendering for uneditable
href/src attributes, we still have to do something for models that manage their
own href/src and edit it, or generate it from another editable attribute.

ve.dm.LinkAnnotation, ve.dm.MWExternalLinkAnnotation: href attribute is edited
directly; in practice MWExternalLinkAnnotation is a full URL and LinkAnnotation
isn't used in the MW integration, but we should still fix them.

ve.dm.MWInternalLinkAnnotation: Generates href based on title attribute, which
can be edited. Links that came directly from Parsoid now render correctly due
to a hack (see bug 51487), but edited links don't render correctly.

ve.dm.ImageNode, ve.dm.MWInlineImageNode, ve.dm.MWBlockImageNode: src attribute
is edited directly; in practice, the MW ones use full URLs (the user doesn't
edit the src directly, and the UI widget gets full URLs from the API) and
ImageNode isn't used in the MW integration, but we should still fix them.

ve.dm.MWCategoryMetaItem, ve.dm.MWLanguageMetaItem: these manage hrefs that can
be edited, but they're never rendered and always absolute, so we don't really
care

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to