https://bugzilla.wikimedia.org/show_bug.cgi?id=53687
Tim Starling <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Summary|No page history visible of |LinksDeletionUpdate |a deleted page on |skipped, causing revisions |nl.wikipedia |to disappear on undelete --- Comment #4 from Tim Starling <[email protected]> --- The binlogs show: * The article was created by an anonymous user at 2013-08-31 20:30:09 * The article was edited by Ronn at 20:31:00, apparently tagging it for deletion * Later in the same second (20:31:00), the article was deleted by Kattenkruid The deletion action went awry. The revisions were copied into the archive table, but they were never deleted from the revision table. The most likely reason for this appears to be a failure of WikiPage::getContent(). The binlog shows WikiPage::onArticleDelete() and SiteStatsUpdate completing successfully, and there was no exception log entry, so it seems that DataUpdate::runUpdates( $updates ) silently did nothing. The !$content case in WikiPage::getDeletionUpdates() seems like a possible culprit. With the ContentHandler project, the critical database consistency action of deleting the revisions from the revision table was moved to LinksDeletionUpdate, and is dependent on the content type. This appears to be an error -- page/revision/archive consistency is not content-type-dependent. In MW 1.5, the revision table delete was well-separated from the link table updates, but they were brought together in r15707, and subsequent refactoring inappropriately maintained this close association. After the botched deletion, the binlogs show: * At 2013-09-01 13:29:57, Kattenkruid attempted to undelete the article. No revisions were inserted into the revision table, presumably because the if ( $exists ) case was hit in PageArchive::undeleteRevisions(). The archive table rows were deleted. The action was not logged, so presumably there was some kind of additional failure. At this point, there would have been a page with no revisions, which is not normally possible. * At 13:31:21, Kattenkruid deleted the revisionless page. * At 2013-09-04 20:26:37, "Look Sharp!" recreated the page by editing it. * At 20:26:47, "Look Sharp!" deleted the page, generating one archive row. The orphaned revision rows are still present in the table (rev_ids 38833406, 38833414), and I can easily recover them by connecting them to a page. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
