https://bugzilla.wikimedia.org/show_bug.cgi?id=53806
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #19 from [email protected] --- Although there are no more mistagged lines since 2013-09-26 22:57, there was some further discussion outside of bz, as we did not see the expected change in number of total zero requests. Neither a change in total zero requests per carrier. Neither a change in the distribution of User-Agents, Accept-Language, or X-Forwarded-For distribution per carrier. This does not match the bug description of the zero tags being wrong. Adam however came up with a different explanation: Maybe the zero tags were not wrong, but the client ips were wrong. This would nicely explain what we saw before and after the fixes. We're tagging the same traffic as before, but this time with correct IP addresses. And code-wise, it seems plausible as well, as the switch to netmapper in 1755cfe5d556f20acae6a9c3cb59e9b38e1327e3 removed the hacky spoof_clientip function. Although the above commit has only been merged on 2013-09-26 23:22 (~25 minutes /after/ the last mistagged line), Adam's explanation seems nevertheless plausible, as the fixes were tested manually on the varnishes beforehand. It seems the combination of Faidon's and Brandon's patches finally fixed the bug for good, and allow to explain the data that we're seeing. Thanks Faidon and Brandon! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
