https://bugzilla.wikimedia.org/show_bug.cgi?id=21638

           Summary: InstantCommons: ForeignAPIRepo doesn't use hashed path
                    for locally stored thumbnails ($this->hashLevels
                    uninitialized)
           Product: MediaWiki
           Version: 1.16-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: Images and files
        AssignedTo: [email protected]
        ReportedBy: [email protected]


InstantCommons places all thumbnails into the top-level thumbs directory
instead of using hashed paths. The problem seems to be that within
ForeignAPIRepo, $this->hashLevels is not initialized. By contrast, it is
initialized in the constructor of FSRepo. Possibly ForeignAPIRepo should be
derived of FSRepo (not FileRepo), as it does use the file system to store
thumbnails? Otherwise, it seems to me that the constructor of ForeignAPIRepo
should also initialize $this->hashLevels. 

Question: would that change need an incremental migration mechanism to move
already stored thumbs from the "thumbs" directory to newly correctly hashed
paths to avoid re-fetching the thumbs again? Such as "if there's no file at the
hash path, look at the non-hashed location, and if there is a matching thumb
there, move it over to its hashed location"?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to