https://bugzilla.wikimedia.org/show_bug.cgi?id=53776

--- Comment #6 from Gabriel Wicke <[email protected]> ---
I took a heap snapshot in production and inspected it in chromium. It seems
that a large number of closures are responsible for the memory leak. From
browsing the data a bit it seems likely that the claimPage closure is
responsible for much of the leaking, which is not surprising as it is called so
often. I also see a large number of Error instances in the heap, which might
indicate that an error code path (transaction rollback?) is responsible for the
leak.

The use of the mysql bindings seems to differ a bit from the documentation at
https://github.com/felixge/node-mysql#transactions. Diffs I see are the
execute() and the end and calling rollback on the return value of
startTransaction rather than db. There are some other structures that look a
bit cyclical like the transUpdateCB binding. Maybe some of this can be
converted to use async (https://github.com/felixge/node-mysql#transactions)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to