https://bugzilla.wikimedia.org/show_bug.cgi?id=55497
Bartosz Dziewoński <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Bartosz Dziewoński <[email protected]> --- I filed the bug 54852 and asked about it on IRC; I've only become aware of the solution after it was merged. I'm okay with the way this was done (per what MZMcBride said above), but I have no stats handy. Splitting the pref out to a tiny WMF-only extension might be a good idea if we want to keep it, though (as suggested on the bug), but I suggest that we keep it killed and create a separate pref for Thanks if it needs it (and possibly migrate the values). (In reply to comment #4) > Did anyone talk to Kaldari, Fabrice, et al before merging this? I don't think > it was intentional to remove the preference without at least notifying the > community that opt-out was being taken away. You can see from the link I > provided that the community and the primary author of the feature (Kaldari) > seem to be taken off-guard here. Benny (who wrote that patch) is (or was last time I asked) the sole programmer currently working on Echo, and Thanks seems to be basically a part of that (Erik Bernhardson was – again, last time I asked – mostly working on Flow; I don't know of any place where this could be checked without asking everyone separately :) ). Kaldari mentioned leaving the E2 team back when it was called E2, so he's probably not that interested. (In reply to comment #6) > Plus, did we check that there were no other currently deployed extensions > depending on the preference? I assume Benny would know. I am not aware of any myself (except for Thanks). > I am unaware of how we can check for dependencies > on preferences (other than say, grepping for the preference name). There isn't any, which is one of the reasons why this was a bad idea. Other experimental tools like VE use separate preferences, IMO Thanks should too. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
