https://bugzilla.wikimedia.org/show_bug.cgi?id=55514
Addshore <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|High |Immediate Target Milestone|--- |MW 1.21 version Severity|normal |blocker --- Comment #2 from Addshore <[email protected]> --- The problem is not the summary, the summary is actually correct for the eventual action. This is instead na issue with lower vs upper case entity ids prepending the guid of claims. ChangeOpClaim parses guids using the claim guid parser. When parsing a claim GUID such as 'q1$0479EB23-FC5B-4EEC-9529-CEE21D6C6FA9' a claim guid object is created. This object consists of an EntityId object and a claim guid string. When we call getSerilization() for this object we get the serilized entityId and the claim guid string. Due to the change to uppercase for EntityIds this means we get. 'Q1$0479EB23-FC5B-4EEC-9529-CEE21D6C6FA9' Therefore when calling $claims->hasClaimWithGuid( $guid->getSerialization() ) we get false when expecting true. Therefore the claim is not removed before the updated claim is added and thus we have duplicate claims with identical GUIDS... -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
