https://bugzilla.wikimedia.org/show_bug.cgi?id=7346





--- Comment #8 from Daniel Hazelton <[email protected]>  2009-11-28 00:45:52 
UTC ---
Neither did I when it started happening. But apparently the URL is constructed
with two ID's so the unique diff can be pulled up. If there is a change made
after that, then the link was changing - however, I didn't try it under a newer
version of the code-base.

And I didn't know that ->getDate() wasn't guaranteed to exist - since it seems
to always exist in my install.

In any case... As I said it would be better to use a link to that specific
revision without setting it as a diff as the guid. Because then it is
guaranteed to not change. And it's just hit me that relying on the specific
date is stupid, so I withdraw my proposed patch. If the URL is changing (or was
- I've since updated to a much more recent code-base) then the duplication
would be seen regardless. (And I have been seeing it)

So... I'm going to work on a more in-depth fix that will change the GUID to a
URL that is that specific revision without the diff contents. I should have a
patch for that by Monday.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to