https://bugzilla.wikimedia.org/show_bug.cgi?id=55580

--- Comment #2 from Brad Jorsch <[email protected]> ---
I see two problems going on here.

First, WikiMap::getWikiName( 'mediawiki' ) will happily return a reference to
"media.wikipedia.org" rather than returning null because that wiki doesn't
actually exist. Fun. Your client is created for that non-existent wiki rather
than for mediawikiwiki. I suppose in our validation for the input we could try
wfGetDB() instead, does that seem sane?

Second, Special:MWOAuth needs to either reject if someone tries to hit it for a
client where $cmr->get( 'wiki' ) !== '*' and !== wfWikiId() or the call to
$oauthServer->getCurrentAuthorization() needs to return the authorization for
$cmr->get( 'wiki' ) rather than wfWikiId(). I'm not sure what the intended
design is. Chris or Aaron?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to