https://bugzilla.wikimedia.org/show_bug.cgi?id=14736


Katherine Ahern <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]




--- Comment #8 from Katherine Ahern <[email protected]>  2009-11-29 
20:47:36 UTC ---
I agree with Platonides that it seems to me when we get the images on the other
sites, we don’t check whether a login cookie was successfully set. I don't
think we need to do any redirects, though.

An idea I had is when we’re getting the images from the other servers (to
tell a user he/she is logged in on other sites), we need to check if the cookie
is properly set, too:

In SpecialAutoLogin.php on the other sites, when we check this:

$data = $wgMemc->get( $key );

We should also test the cookie:

if($_COOKIE["centralAuthSession"] == $sessionID){ //or however you check for
logged-in-ness with the cookie
        $cookieSet = true; 
} else {
        $cookieSet = false;
} 

Then you change this line:

if( !$data ) {

to

if( !$data || !$cookieSet ) {


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to