https://bugzilla.wikimedia.org/show_bug.cgi?id=55668
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Jenkins -1s over JSDuck |Jenkins: jsduck test is |warnings unrelated to patch |sometimes passing when the | |build contains warnings --- Comment #2 from Krinkle <[email protected]> --- I'm rephrasing this bug to what is the real bug, which incidentally is contradictory to your premise. Jobs should fail regardless of whether files that seemingly caused it were altered in said patch set. Master is always passing (enforced by our gate), and if a patchset made it fail, that needs to be addressed first. If someone bypassed the gate or if Jenkins was changed without being backwards compatible either that change needs to be rollbacked or someone is presumably already working on hotfixing the (whether or not anticipated) breakage. I'm not necessarily saying jobs absolutely must fail if the error seems to have been there already without this patchset. Merely that the problem it is causing now is actually something very different, and in general I believe at at this point anything we'd do to "ignore" errors will do more harm than good (e.g. changing jshintrc can seriously alter and break things even though the error message will not appear to originate from that file, and changes might fix one error and introduce another). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
