https://bugzilla.wikimedia.org/show_bug.cgi?id=21711





--- Comment #4 from Jack D. Pond <[email protected]>  2009-11-30 17:11:27 
UTC ---
(In reply to comment #3)
> I have a feeling that hooks should be in the core unless their users extend
> OpenID specifically.

Sergey, agreed, but that depend on the definition of "core".  If "core"
includes standard Special pages like SpecialUserLogin, this hook is already
included in there, thrice as a matter of fact, once in
addNewAccountMailPassword() and twice in addNewAccount(), all 3 times
immediately prior to addNewUserLogEntry() method.  The problem is that OpenID
extension bypasses many of the checks and functional processes of the standard
login and uses primatives.  This goes back to the question I discussed with you
before about whether the two should be merged - I'd personally like to see this
functionality included in the "core" and even used on WP.

In this case I use this particular hook for the exact same reason - to provide
functionality when a new user registers.  Other hooks that have relevance for
OpenID would be:

AbortNewAccount - http://www.mediawiki.org/wiki/Manual:Hooks/AbortNewAccount
AbortLogin - http://www.mediawiki.org/wiki/Manual:Hooks/AbortLogin
AuthPluginAutoCreate -
http://www.mediawiki.org/wiki/Manual:Hooks/AuthPluginAutoCreate
LoginAuthenticateAudit -
http://www.mediawiki.org/wiki/Manual:Hooks/LoginAuthenticateAudit
UserLoginMailPassword -
http://www.mediawiki.org/wiki/Manual:Hooks/UserLoginMailPassword 
User::mailPasswordInternal -
http://www.mediawiki.org/wiki/Manual:Hooks/mailPasswordInternal
UserLoginComplete -
http://www.mediawiki.org/wiki/Manual:Hooks/UserLoginComplete
UserCreateForm - http://www.mediawiki.org/wiki/Manual:Hooks/UserCreateForm

Maybe the question is really should a different hook be provided that
distinguishes it from standard logins, but much of this functionality is useful
in both - and serves the exact same purpose in both generally.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to