https://bugzilla.wikimedia.org/show_bug.cgi?id=4421
--- Comment #33 from Rob Lanphier (RobLa) <[email protected]> 2009-12-06 06:19:48 UTC --- Created an attachment (id=6859) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6859) v2 patch - handles upload, still buggy New version of a patch. Still some testing, known bugs and cleanup to do, but looking for last minute feedback before I finish this off. The big change is that there's a new field in the image table (img_file_ext) along with corresponding changes in oldimage and filearchive. It appears as though the check on upload was already mostly coded, and there was even a $wgCheckFileExtensions variable that I didn't notice in my first version (looks like its an antique, too) Known bug: uploading an image without an extension will cause the DB to end up in incorrect state. Here's my test plan: * Image renaming: ** Upload Foo.jpg ** Rename Foo.jpg to Foo ** Rename Foo to Foo.jpeg ** Rename Foo.jpeg to Foo.gif ** Upload Bar (GIF file) ** Rename Bar to Bar.gif * Set $wgSaveDeletedFiles=true * Set $wgFileStore['deleted']['directory'] to valid directory * Delete, then undelete an image * Upload a new version of an image ** With no extension ** with proper extension * Change configuration of default extension from "jpg" to "jpeg". Deal with images from before transition * Install MW 1.15, set wgCheckFileExtensions=false, upload images (with/without matching extensions) then upgrade to new version and check images * Fresh install of MediaWiki uploading both images with/without matching extension in title -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
