https://bugzilla.wikimedia.org/show_bug.cgi?id=55550

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #7 from [email protected] ---
Matt, great sleuthing.

I agree the 
        $out->addModuleStyles( 'mw.PopUpMediaTransform' );
is redundant, also probably
        $out->addModuleStyles( 'mw.PopUpMediaTransform' );
for the similar parser hook.

TMH's BeforePageOutput hook loads 'mw.PopUpMediaTransform', which specifies the
dependency on 'mw.MwEmbedSupport'.  But MwEmbedSupport in addStartupModules()
explicitly loads 'mw.MwEmbedSupport' and all the files that it depends on. I
think none of that should be necessary with latest MediaWiki, maybe it's there
for backward compatibility with 1.17.  I submitted gerrit 92052.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to