https://bugzilla.wikimedia.org/show_bug.cgi?id=55550
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from Krinkle <[email protected]> --- (In reply to comment #7) > Matt, great sleuthing. > > I agree the > $out->addModuleStyles( 'mw.PopUpMediaTransform' ); > is redundant, [..] > > TMH's BeforePageOutput hook loads 'mw.PopUpMediaTransform' > [..] I submitted Gerrit change #92052. One thing to keep in mind when "fixing" issues like this is the styling if non-JavaScript elements (eg. PHP-served HTML output) as, unless position/top is set these modules will load async and would cause a FOUC. Of course, that doesn't justify silly code that loads the stylesheet twice but it isn't always obvious that one can simply be removed. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
