https://bugzilla.wikimedia.org/show_bug.cgi?id=56277
Matthias Mullie <mmul...@wikimedia.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|PATCH_TO_REVIEW |NEW
--- Comment #4 from Matthias Mullie <mmul...@wikimedia.org> ---
Patch was already in Gerrit: https://gerrit.wikimedia.org/r/#/c/92903/
I had indeed completely broken this with the history patch, which was also
already using these same messages (as does, I think, the display of a moderated
message, which I'll be fixing next)
Andrew: I agree that I'd prefer to have the parameters in HistoryRecord too:
I'd prefer to only have to call HistoryRecord::getMessage() without any
parameters, and have that method take care of it by itself.
However, some of the messages are rather complex, and need info that is only
available in separate objects. If we were to let HistoryRecord deal with those
by itself, it would have to have all these objects injected already. I've for
now decided to let HistoryRenderer inject these when needed, via the
getMessage() call. If you can think of a neater solution, by all means, I'd
love it :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
