https://bugzilla.wikimedia.org/show_bug.cgi?id=56405

--- Comment #16 from Bawolff (Brian Wolff) <[email protected]> ---
(In reply to comment #13)
> A possible short-term workaround is that we could change
> $wgMinimumVideoPlayerSize back to 200px specifically for Commons. That would
> eliminate the problem for the majority of embedded videos, but still keep the
> pop-up behavior on Wikipedias. It should be emphasized, though, that this is
> just a workaround and the underlying bug would still need to be fixed at some
> point.

I submitted a patch. Somewhat of a semi-cop out (Just disabling the feature for
embeds). However on the other hand, that feature wouldn't look good in an
iframe even if it did work. I agree that if it takes a while for that patch to
be reviewed (or if people don't like my patch) that we should revert the config
change until all this is sorted.


The iframe embedding code itself is a bit on the scary side (After looking at
it, I'm really unclear how the media player js even seems to get loaded at all.
If you enable ?debug=yes, the entire thing falls apart), so it could perhaps do
with a strong look at how to make it more robust. But that's a separate issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to