https://bugzilla.wikimedia.org/show_bug.cgi?id=56226

--- Comment #11 from Bawolff (Brian Wolff) <[email protected]> ---

> 
> The minimal test case also suggests a different approach, just remove the &
> operator from the arguments to those hooks. There's no real need for them,
> and
> I'm assuming they are a hold over from PHP4 days.

Hmm, I thought that wouldn't result in a behaviour change, but apparently that
causes exceptions to be thrown about how the function wants an object (in for
example cite).

Perhaps just removing the reference for the &$this->mStripState would fix it
with less breakage, since most people subsribing to those hooks don't include
that argument in the signature... I'm not really sure.

Or could do that other hacky thing of making an extra reference when doing the
assignment to strip state. Not sure.

Mean time, maybe just change Translate to not trigger it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to