https://bugzilla.wikimedia.org/show_bug.cgi?id=57146
--- Comment #12 from kipod <[email protected]> --- (In reply to comment #9) > (In reply to comment #7) > > there isn't a single callsite for this function, > > Lines 254, 276, 571 of morebits call this function. you are correct - i missed those in the search (my bad - i searched with a space). however, this only works if the original "title" is empty. if you try to attach a tipsy tip to a node with existing hint (i.e., a non-empty "title" attribute), fallback is not usable. my patch does not break this case. with current code, fallback only works if the node does not have a title, or if the node has some other empty attribute, and you pass to tipsy "title" with the name of this attribute. my patch will not break the first case: if the original "title" is empty, fallback will still work. with my patch, you could use "fallback" even when the original title is not empty, by passing title: '', fallback: yourstring to tipsy. with current code, you just can't use fallback in this case. (of course, with the patch, you can cut the detour and just pass title: yourtring ) of course, with my patch, you could bypass "fallback" altogether by passing the actual string as "title". the only backward-compatibility case my patch *does* break is the case where you want a tip with the value of some attribute: for instance, you might want to see the ID of every node matching some selector, you could do $(selector).tipsy({title: 'id'}); this is such an esoteric use, that it makes no sense to force everyone who wants to return a known string will be forced to use a function in order to save this esoteric case from the need to write title: function(){return $(this).attr('id'); } bottom line: 1) apologies for my long and winding comments 2) my patch will *not* break the twinkle use case, or any other case where the "title" attribute does not exist or is empty, which are the only cases where "fallback" works anyway. peace. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
