https://bugzilla.wikimedia.org/show_bug.cgi?id=57363

       Web browser: ---
            Bug ID: 57363
           Summary: Enhance hooks.rb in mediawiki-selenium gem to warn
                    when BROWSER_LABEL is undefined
           Product: Wikimedia
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Quality Assurance
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected]
    Classification: Unclassified
   Mobile Platform: ---

This is a follow-up to this recent change to the VisualEditor browser tests:

https://gerrit.wikimedia.org/r/#/c/96793/

Since a user may neglect to explicitly export a value for the BROWSER_LABEL
environment variable, it might be a good idea to enhance hooks.rb for the
mediawiki-selenium RubyGem to add a warning where that value is undefined.  

The danger is that where the BROWSER_LABEL value is undefined, individual tests
will not target the intended wiki pages, since those pages are expected to have
the BROWSER_LABEL string included in the page URL.

The hooks.rb file already issues similar warnings for the MEDIAWIKI_USER and
MEDIAWIKI_PASSWORD variables in the "Before('@login')" method:

https://github.com/wikimedia/mediawiki-selenium/blob/master/lib/mediawiki/selenium/hooks.rb

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to