https://bugzilla.wikimedia.org/show_bug.cgi?id=21919





--- Comment #14 from Brian McNeil <[email protected]>  2009-12-31 
01:23:45 UTC ---
Priyanka,

I'm looking at the changes you checked in (I'm a noob to php)

#par is used by dpl_param on line 305 thus:

$feedType = explode('/',$par,2)

What is actually in $par? It appears the result of the operation on line 305
should produce an array based on items separated by '/'.

If $par is the url path after "Special:GNSM/" then line 305 will only work if
the "?" and parameters after it are stripped before it gets to there. That
would also mean that "Special:GNSM/<feedtype>/<junk path and name>?option=xxx"
would work.

Of course, "Special:GNSM/<feedtype>/<url-escaped-feed-title>?option=xxx" would
be nice and allow for more descriptive URLs.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to