https://bugzilla.wikimedia.org/show_bug.cgi?id=57909
Web browser: ---
Bug ID: 57909
Summary: Bogus entries in externallinks table due to unescaping
of &%=+
Product: MediaWiki
Version: 1.23-git
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Parser
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
Consider this URL:
http://example.com/index.php?foo=bar%26baz%3Dquux%2Bquux
It has one parameter, foo, with the value "bar&baz=quux+quux". Place this in an
article and the externallinks table will contain this URL instead:
http://example.com/index.php?foo=bar&baz=quux+quux
This has *two* parameters, foo with the value "bar" and baz with the value
"quux quux".
Then try this URL:
http://example.com/index.php?foo=%25xx
The value of foo is "%xx". But put it into an article, and externallinks will
contain this URL instead:
http://example.com/index.php?foo=%xx
That's not even valid.
The problem lies in Parser::replaceUnusualEscapesCallback, it will unescape
%25, %26, %2B, and %3D despite these all having special meaning in a URL when
unescaped. I see a similar-sounding problem was reported in bug 4781, which was
closed as "fixed" with no reference to the revision in which it was fixed. Bug
40267 also touched upon this issue, but these real problems appear to have been
overlooked since the reporter there focused on the unescaping of various safe
characters rather than only these unsafe ones.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
