https://bugzilla.wikimedia.org/show_bug.cgi?id=37702
--- Comment #16 from Marcin Cieślak <[email protected]> --- An early fix for this is in gerrit change I326bb4a189bf881299b9fb678033a927b916efac (this just replays some SQL with ALTER TABLE ... ADD CONSTRAINT plus makes a copy of the "mwuser" table). We might actually want to split tables.sql into two files to make it work this way :) Before this change is applied I had 3 errors and 3 failures in the unit tests: 1) TestORMRowTest::testSaveAndRemove fails because of test_id (bug 37601) 2) SiteSQLStoreTest::testGetSites fails because of bug 37601 3) SiteSQLStoreTest::testSaveSites fails because of bug 37601 3 failures are: 1) WikiPageTest::testDoDeleteArticle most probably this bug 2) WikiPageTest::testDoDeleteUpdates as well 3) SiteSQLStoreTest::testReset I didn't check yet -------------------------------------------------------- After change I326bb4a189bf881299b9fb678033a927b916efac is applied I get 16 errors and 2 failures: 1) BlockTest::testBlockedUserCanNotCreateAccount 2) BlockTest::testCrappyCrossWikiBlocks - those fail because the user id they use is not yet in the DB (easy) 3) LinksUpdateTest::testUpdate_pagelinks 4) LinksUpdateTest::testUpdate_externallinks 5) LinksUpdateTest::testUpdate_categorylinks 6) LinksUpdateTest::testUpdate_templatelinks 7) LinksUpdateTest::testUpdate_imagelinks 8) LinksUpdateTest::testUpdate_langlinks 9) LinksUpdateTest::testUpdate_page_props - those fail becaue page_id they refer to in those tables is not (yet) in the database 10) 11) 12) and 13) are RevisionStorageTest::testUserWasLastToEdit - fail because page_d they refer to is not yet in the database (fixed with gerrit change I653a8bccdaa748a9bea453cd1dbf609a30e1ff6f) 14) TestORMRowTest::testSaveAndRemove 15) SiteSQLStoreTest::testGetSites 16) SiteSQLStoreTest::testSaveSites - those fail as they failed before the patch (bug 36701) What is interesting is that WikiPageTest::testDoDeleteArticle no longer fails there, but WikiPageTest::testDoDeleteUpdates and SiteSQLStoreTest::testReset continue to do so. Actually I believe testDoDeleteUpdates should be fixed with constraints and triggers since the database can delete dependent records for us. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
