https://bugzilla.wikimedia.org/show_bug.cgi?id=47375

Krinkle <krinklem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krinklem...@gmail.com
            Summary|Transaction idle or         |Address "DB transaction
                   |pre-commit callbacks still  |callbacks still pending"
                   |pending                     |warnings from Database.php

--- Comment #8 from Krinkle <krinklem...@gmail.com> ---
There are four different code paths emitting this type of notice:

@ class Database
public function close() {
    if ( count( $this->mTrxIdleCallbacks ) ) {
        throw new MWException( "Transaction idle callbacks still pending." );
    ...



@ class Database
public function close() {
    ...
    if ( $this->mConn &&
        $this->trxLevel() &&
        !$this->mTrxAutomatic
    ) {
        wfWarn( "Transaction still in progress (from {$this->mTrxFname}), " .
        " performing implicit commit before closing connection!" );
    ...

@ class Database
public function __destruct() {
    if ( $this->mTrxLevel && $this->mTrxDoneWrites ) {
        trigger_error( "Uncommitted DB writes (transaction from
{$this->mTrxFname})." );
    ...


@ class Database
public function __destruct() {
    ...
    if ( count( $this->mTrxIdleCallbacks ) || count(
$this->mTrxPreCommitCallbacks ) ) {
        ...
        trigger_error( "DB transaction callbacks still pending (from
$callers)." );
    ...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to