https://bugzilla.wikimedia.org/show_bug.cgi?id=57546
--- Comment #3 from Chris Steipp <[email protected]> --- In general, everything looks good. Just a few things: Wikimania/Scholarship/Controllers/Login.php * handlePost - sanity check $next before you redirect Wikimania/Scholarship/Controllers/Review/Application.php * handleGet - $id = $this->request->get( 'id' ); seems like this isn't validated Wikimania/Scholarship/Controllers/Review/Phase1List.php and Phase2List.php * handleGet - Please strip any leading "=". Probably want to quote entries in case they contain commas. Wikimania/Scholarship/Forms/Apply.php * Do you really need IP in the db? Is there a cleanup job to remove them to comply with privacy policy? Can I get source of js/flexigrid.pack.js? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
