https://bugzilla.wikimedia.org/show_bug.cgi?id=58312
Brad Jorsch <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Brad Jorsch <[email protected]> --- I'm not sure that the change in definition for ChangeTags::listDefinedTags() made in Gerrit change 81830 (after change tags were added to OAuth) really makes sense. According to the comment on that function (which wasn't updated to match the changed definition), the purpose of that list is to list tags that should show up on Special:Tags even when they aren't attached to anything. If a tag shouldn't show up when it's not attached to anything (as may be the case for OAuth's tags if the consumer doesn't take any logged actions), then it shouldn't be returned by that function. Gerrit change 81830 changed that definition, now there is no straightforward way to say "active" without also forcing it to show up in the list when there are 0 tagged changes. The non-straightforward way is to query if there are any tagged changes for each tag before adding it to the list of "defined" tags. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
