https://bugzilla.wikimedia.org/show_bug.cgi?id=57939
Faidon Liambotis <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Faidon Liambotis <[email protected]> --- GeoIP being used in other extensions already doesn't say much about whether it /should/ be used for this purpose, as the same could be argued for any of its other uses :) In fact, the current usage of the GeoIP lookups in general is problematic for other reasons already and we have plans of changing it in the future (see #57126, as filled by Ori). If the shop has restrictions on where from it can be used, then this certainly shouldn't affect each and every page load on every project of ours. Having every Wikipedia reader's browser compute in Javascript whether the shop link should be displayed or not (and modify the DOM for a large percentage of our user base) sounds, frankly, crazy to me. Unless you have evidence to support that a significant percentage of readers shop from the site *and* you have a lot of false positives of users entering the site and saying "bummer, this is expensive", merging this sounds extremely obvious to me. Having a link is fine, but the extra computation because of application logic is not. If you think this functionality is useful for the shop, then this logic should be pushed into the shop site itself; the extra pointless click will only affect a tiny minority of users who I'm sure wouldn't mind seeing the "sorry it's so expensive to your place" notice that much. On a more general note, the site currently is full of "small harmless snippets" like that that overall make the performance horrendous; it's essentially death by a thousand cuts, and we finally have someone who's actually going around and providing patches to fix all of these cuts, so I'm inclined to just let them make those calls :-) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
