https://bugzilla.wikimedia.org/show_bug.cgi?id=58479
Web browser: ---
Bug ID: 58479
Summary: File class hierarchy is crazy
Product: MediaWiki
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: File management
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected],
[email protected], [email protected],
[email protected]
Blocks: 700
Classification: Unclassified
Mobile Platform: ---
The File class (and related classes) should have a clearer class hierarchy.
*ArchivedFile doesn't extend anything
Besides all the duplicated code, this means that people who use "File" type
hints, may be in for a nasty surprise
*ForeignDBFile is a subclass of LocalFile
This just doesn't really make sense logically. Even if code wise there isn't
much difference, having a new class, say DBFile, that both LocalFile and
ForeignDBFile extend, with perhaps minimal code in the new LocalFile class.
*Subclasses seem to be made on 2 dimensions - is the file current/old/deleted,
and the repo type of the File. This should maybe be investigated if this is
really a good way of splitting things up.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
