https://bugzilla.wikimedia.org/show_bug.cgi?id=14717


Jools Wills <b...@exotica.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #5157 is|0                           |1
           obsolete|                            |
Attachment #5839 is|0                           |1
           obsolete|                            |




--- Comment #13 from Jools Wills <b...@exotica.org.uk>  2010-01-13 19:53:29 UTC 
---
Created an attachment (id=6953)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6953)
add skin specific config to choose fixes for wikibits.js to include

Earlier patch was rejected by Brion, as it was monobook specific, and didn't
address the other css files for other browsers. Here is a patch that has an
additional skin variable that contains an associative array where each "buggy
browser" can have an associated css fix file with it. I have included this for
monobook. I don't think any of the other skin's need these fixes.

I also changed the parameter for makeGlobalVariablesScript to be the skin
object/class rather than just the name of the skin, so it can get the data
about the required css' from the skin to pass to the javascript. I chose this
over adding an additional parameter, in case more stuff was needed in the
future, but feel free to make it two parameters if preferred,


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to