https://bugzilla.wikimedia.org/show_bug.cgi?id=22093
Bryan Tong Minh <bryan.tongm...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bryan.tongm...@gmail.com
--- Comment #1 from Bryan Tong Minh <bryan.tongm...@gmail.com> 2010-01-13
21:33:23 UTC ---
I only took a quick look, but some general comments. Does it really need to
duplicate every single function from DatabaseBase? selectSQLText() looks
completely copied. I also think there may be unnecessary duplication between
the two mssql database classes. Things like SQL generation can be completely
shared, only things that call the underlying database interface ought to be
different.
What is exactly the advantage between using the two drivers?
Also some specific notes:
> -...@ini_set( "display_errors", true );
> +...@ini_set( "display_errors", false );
?
> + # since MSSQL doesn't recognize the infinity keyword, set date
> manually
> + # TO-DO: refactor for better DB portability and remove magic
> date
> + $dbw = wfGetDB(DB_MASTER);
> + if($dbw instanceof DatabaseMssqlnative)
> + {
> + return '3000-01-31 00:00:00.000';
> + }
This should be implemented as Database*::infinity()
> - GROUP BY tl_namespace, tl_title
> + GROUP BY tl_title, tl_namespace
Why?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
