https://bugzilla.wikimedia.org/show_bug.cgi?id=58651
Web browser: ---
Bug ID: 58651
Summary: Don't use fake user agent
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: GWToolset
Assignee: wikibugs-l@lists.wikimedia.org
Reporter: s...@reedyboy.net
CC: bawolff...@gmail.com, d_ent...@yahoo.com,
mtrac...@member.fsf.org
Classification: Unclassified
Mobile Platform: ---
GWToolset should really use a proper user-agent, not some copy paste that is
very much not what is doing the request.
I'm not sure there's much need for it to be configurable either, but that's
another story
public static $http_agent = 'Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3)
Gecko/20041001 Firefox/0.10.1';
For example, ForeignAPIRequest uses:
public static function getUserAgent() {
return Http::userAgent() . " ForeignAPIRepo/" . self::VERSION;
}
And for Squid purging:
$request[] = "User-Agent: " . Http::userAgent() . ' ' . __CLASS__;
Try something like: Http::userAgent() . " GWToolset/0.0.1-dev";
Though you might want to add a constant for the GWToolset version and re-use
this here and in the loader file
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
