Web browser: ---
            Bug ID: 58726
           Summary: refactor duplicate code into getNotificationIconUrl()
           Product: MediaWiki extensions
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Echo
    Classification: Unclassified
   Mobile Platform: ---

formatters/BasicFormatter.php's format() and includes/EmailFormatter.php
getNotifIcon() were already duplicating code to determine the URL of a
notification icon. With the fix for bug 58705 it's 20 lines of identical code.

The only difference between them is getNotifIcon() calls wfExpandUrl(); this
e.g. could be an optional parameter to a common function or method.

You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
Wikibugs-l mailing list

Reply via email to