https://bugzilla.wikimedia.org/show_bug.cgi?id=58731

       Web browser: ---
            Bug ID: 58731
           Summary: getOAuthAccessToken() should check title before
                    invoking isSpecial()
           Product: MediaWiki extensions
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: OAuth
          Assignee: wikibugs-l@lists.wikimedia.org
          Reporter: sp...@wikimedia.org
                CC: aschulz4...@gmail.com, bjor...@wikimedia.org,
                    cste...@wikimedia.org, dga...@wikimedia.org
    Classification: Unclassified
   Mobile Platform: ---

The fatal stack trace in Bug 58705 suggests that calling  $wgLang->getDir() to
determine RTL direction can trigger establishing a user, which can run the
UserLoadFromSession hook, in response OAuth's getOAuthAccessToken() calls
$title->isSpecial()... which crashes with "Fatal error: Call to a member
function isSpecial() on a non-object" because if you do this early enough, 
RequestContext::getMain() ->getTitle() doesn't return a title object.

Bug 58380 ended up at the same fatal  It seems there enough ways this could
fail that the getOAuthAccessToken() function should guard against it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to