Web browser: ---
            Bug ID: 58731
           Summary: getOAuthAccessToken() should check title before
                    invoking isSpecial()
           Product: MediaWiki extensions
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: OAuth
    Classification: Unclassified
   Mobile Platform: ---

The fatal stack trace in Bug 58705 suggests that calling  $wgLang->getDir() to
determine RTL direction can trigger establishing a user, which can run the
UserLoadFromSession hook, in response OAuth's getOAuthAccessToken() calls
$title->isSpecial()... which crashes with "Fatal error: Call to a member
function isSpecial() on a non-object" because if you do this early enough, 
RequestContext::getMain() ->getTitle() doesn't return a title object.

Bug 58380 ended up at the same fatal  It seems there enough ways this could
fail that the getOAuthAccessToken() function should guard against it.

You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
Wikibugs-l mailing list

Reply via email to