output by CleanChanges if tidy off messes up monobook and creates invalid html
bugzilla-daemon
Thu, 26 Dec 2013 05:01:47 -0800
https://bugzilla.wikimedia.org/show_bug.cgi?id=58439
--- Comment #3 from Mateusz Maćkowski <matx-1...@o2.pl> ---
After about 2 hours of investigating, I finally, I think, know everything about
this bug.
Look at the EnhancedChangesList.php in old MW (dunno which version exactly):
public function endRecentChangesList() {
return $this->recentChangesBlock() . parent::endRecentChangesList();
}
(FYI: parent::endRecentChangesList() returns '</ul>' or '')
And new one:
public function endRecentChangesList() {
return $this->recentChangesBlock() . '</div>';
}
What was the problem?
CleanChanges_body.php:
public function endRecentChangesList() {
return parent::endRecentChangesList() . '</div>';
}
As you probably think already, the function above was really something like:
return $this->recentChangesBlock() . '</div>' . '</div>';
And that caused the problem.
There wasn't such problem in older version of MediaWiki, because
ChangesList::endRecentChangesList() returned only '' or '</ul>', so adding
'</div>' was necessary. That changed in newer version of MW, which caused an
extension to output '</div>' 2 times.
The only matter that I'm thinking about now is that my patch caused the
extension be unusable (causing the same problem) in older versions of
MediaWiki... Is it a serious problem?
PS. "older version of MediaWiki" means here something between 1.23alpha and
current git version. I don't know really; I have a copy of it on my personal
server (I think I downloaded it as a zip from official MW website...)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l