https://bugzilla.wikimedia.org/show_bug.cgi?id=55597

sp...@wikimedia.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|PATCH_TO_REVIEW             |NEW

--- Comment #13 from sp...@wikimedia.org ---
LiquidThreads adds a test to the watchlist query to exclude its Thread
namespace:
    AND (page_namespace != '90')

But Flow changes don't have a namespace, so this is (NULL != '90') which in the
hell of SQL evaluates to NULL not 1, so they were getting excluded too.

For posterity, a production Special:Watchlist query on a Wiki with Flow and LQT
(but not Wikibase/Wikidata) looks like:

SELECT  rc_id,
        rc_timestamp,
        rc_user,
        rc_user_text,
        rc_namespace,
        rc_title,
        rc_comment,
        rc_minor,
        rc_bot,
        rc_new,
        rc_cur_id,
        rc_this_oldid,
        rc_last_oldid,
        rc_type,
        rc_source,
        rc_patrolled,
        rc_ip,
        rc_old_len,
        rc_new_len,
        rc_deleted,
        rc_logid,
        rc_log_type,
        rc_log_action,
        rc_params,
        wl_notificationtimestamp,
        (
          SELECT  GROUP_CONCAT(ct_tag SEPARATOR ',')
            FROM `change_tag`
            WHERE ct_rc_id=rc_id
        )
  AS ts_tags,fp_stable,fp_pending_since
  FROM `recentchanges`
        INNER JOIN `watchlist` ON (wl_user = '19998' AND
(wl_namespace=rc_namespace) AND (wl_title=rc_title))
        LEFT JOIN `page` ON ((rc_cur_id=page_id))
        LEFT JOIN `flaggedpages` ON ((fp_page_id = rc_cur_id))
  WHERE (rc_timestamp > '20131228230259')
    AND ((rc_this_oldid=page_latest) OR rc_type IN ('3','142') )
    AND (page_namespace != '90')
  ORDER BY rc_timestamp DESC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to