https://bugzilla.wikimedia.org/show_bug.cgi?id=59126

--- Comment #6 from Tony Thomas <01tonytho...@gmail.com> ---
(In reply to comment #5)
> Bad fix in my opinion.
> 
> You have only removed one part of a AND condition, that means the condition
> itself was changed and not only dead code path removed.
> 
> For initEditCount.php:
> You have changed the meaning for 'background mode' from 'LoadBalancer with
> more
> than one server OR mysql version < 4.1' to 'LoadBalancer with more than one
> server OR mysql'.
so it should be like 'LoadBalancer with more than one
> server OR FALSE'. ?
> 
> For storage/fixBug20757.php:
> $lowerLeft is now a undefined variable for non-mysql server
the else should be left untouched ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to