https://bugzilla.wikimedia.org/show_bug.cgi?id=54181

Andre Klapper <aklap...@wikimedia.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |PATCH_TO_REVIEW

--- Comment #44 from Andre Klapper <aklap...@wikimedia.org> ---
<tl;dr> Scroll to last paragraph.

== General info on differences between testing and production: 
Production Bugzilla has attachment_base set (bug-attachment.wikimedia.org)
which is not the case on Labs, hence testing situation is not the same. Plus I
wonder why Labs does not display any sidebar & wrong CSS style in IE. Grmpf.

== Testing:
Using IE8 on XP SP3 in compatibility mode on boogs.wmflabs.org with
allow_attachment_display=Off and...

=== 1) https://gerrit.wikimedia.org/r/#/c/90546/4/ not applied and my previous
naive attempt applied by adding the three lines
    if ($contenttype =~ /^image\/(png|gif|jpeg)$/) {
            $disposition = "inline";
    }
in attachment.cgi:395, which makes Bugzilla behave as if
allow_attachment_display was set to "On" for files with mimetypes GIF/JPG/PNG,
* GIF/JPG/PNG standard images with correct mime types in
http://boogs.wmflabs.org/show_bug.cgi?id=13#c1 to #c3 are directly displayed in
the browser without warning (due to hack above). 
* HTML/JS attachment in http://boogs.wmflabs.org/show_bug.cgi?id=13#c4 asks if
it should be opened before its JS is executed. 
* Broken "image" files (which contain HTML):
http://boogs.wmflabs.org/show_bug.cgi?id=13#c5 and #c6 display a red 'broken'
icon (same as FF26) and #c7 (BMP) asks to open an application.

=== 2) https://gerrit.wikimedia.org/r/#/c/90546/4/ not applied && after
removing the three custom lines in 1),
* GIF/JPG/PNG standard images with correct mime types in
http://boogs.wmflabs.org/show_bug.cgi?id=13#c1 to #c3 ask to open an
application.
* HTML/JS attachment in http://boogs.wmflabs.org/show_bug.cgi?id=13#c4 asks if
it should be opened before its JS is executed.
* Broken "image" files (which contain HTML):
http://boogs.wmflabs.org/show_bug.cgi?id=13#c5 to #c7 ask to open an
application.

=== 3) https://gerrit.wikimedia.org/r/#/c/90546/4/ applied:
* GIF/JPG/PNG standard images with correct mime types in
http://boogs.wmflabs.org/show_bug.cgi?id=13#c1 to #c3 are directly displayed in
the browser without warning (due to Gerrit patch).
* HTML/JS attachment in http://boogs.wmflabs.org/show_bug.cgi?id=13#c4 asks if
it should be opened before its JS is executed.
* Broken "image" files (which contain HTML):
http://boogs.wmflabs.org/show_bug.cgi?id=13#c5 to #c7 ask to open an
application.

Hence patch in https://gerrit.wikimedia.org/r/#/c/90546/4/ seems to work as
expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to